dmenu: small XmbLookupString code improvements
* Increase the length of composed strings to the same limit as st (32 to 64 bytes). * Initialize ksym to NoSymbol to be safe: currently this is not an issue though. * Add comments to clarify the return values of XmbLookupString a bit.
This commit is contained in:
		
							
								
								
									
										8
									
								
								dmenu.c
									
									
									
									
									
								
							
							
						
						
									
										8
									
								
								dmenu.c
									
									
									
									
									
								
							| @ -324,19 +324,19 @@ movewordedge(int dir) | ||||
| static void | ||||
| keypress(XKeyEvent *ev) | ||||
| { | ||||
| 	char buf[32]; | ||||
| 	char buf[64]; | ||||
| 	int len; | ||||
| 	KeySym ksym; | ||||
| 	KeySym ksym = NoSymbol; | ||||
| 	Status status; | ||||
|  | ||||
| 	len = XmbLookupString(xic, ev, buf, sizeof buf, &ksym, &status); | ||||
| 	switch (status) { | ||||
| 	default: /* XLookupNone, XBufferOverflow */ | ||||
| 		return; | ||||
| 	case XLookupChars: | ||||
| 	case XLookupChars: /* composed string from input method */ | ||||
| 		goto insert; | ||||
| 	case XLookupKeySym: | ||||
| 	case XLookupBoth: | ||||
| 	case XLookupBoth: /* a KeySym and a string are returned: use keysym */ | ||||
| 		break; | ||||
| 	} | ||||
|  | ||||
|  | ||||
		Reference in New Issue
	
	Block a user